Removing ::before ::after padding hack on markdown #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broccolini
reviewed
Oct 5, 2017
.storybook/preview-head.html
Outdated
| @@ -1,2 +1 @@ | |||
| <link rel="stylesheet" href="https://unpkg.com/primer-css@9.2.0/build/build.css"> | |||
| padding: 0; | ||
| padding-top: 0.2em; | ||
| padding-bottom: 0.2em; | ||
| padding: 0.2em 0.4em; |
There was a problem hiding this comment.
One day in the future we should bring this into our proposed em-based scale and stick to common fractions.
| letter-spacing: -0.2em; // this creates padding | ||
| content: "\00a0"; | ||
| } | ||
| border-radius: 3px; |
There was a problem hiding this comment.
Use the $border-radius variable 😝
| @@ -0,0 +1,18 @@ | |||
| import React from 'react' | |||
There was a problem hiding this comment.
🎉 Yay for adding more stories! It would be great to add the rest of the markdown styles when you get a chance.
|
This was deployed to review-lab https://github.com/github/github/pull/79702 and I didn't find any regressions. |
28 tasks
This was referenced Dec 22, 2022
This was referenced Jan 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the
::before, ::afterhack, the code blocks are not fully selectable. This pr removes the hack. It's been so long since this was introduced (~3 years ago) It's not fully clear what this was preventing. I think it has to do with scrollbars in Firefox and Android browsers.I'd like to try and roll that back, then test on prod to see what bugs might crop up.
cc https://github.com/github/github/issues/58168